feat(tableau): review reporting and debug traces #12015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
datahub-cyborg
bot
added
the
needs-review
hsheth2
approved these changes
Dec 3, 2024
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
| raise ValueError( | ||
| f"Unable to login (invalid/expired credentials or missing permissions): {str(e)}" | ||
| ) from e | ||
| message = f"Error authenticating with Tableau. Note that Tableau personal access tokens expire if not used for 15 days or if over 1 year old: {str(e)}" |
There was a problem hiding this comment.
let's keep the "(invalid/expired credentials or missing permissions)" bit
unless that's not applicable for PersonalAccessTokenAuth authentication?
datahub-cyborg
bot
added
merge-pending-ci
…u.py Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces usage of the to-be-deprecated
report.report_warningwithreport.warning.This update also improves visibility for certain exception errors and debug traces, while carefully ensuring unnecessary verbosity is not being added.
Checklist