Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs-website) fix links #12019

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat(docs-website) fix links #12019

merged 1 commit into from
Dec 3, 2024

Conversation

jayacryl
Copy link
Collaborator

@jayacryl jayacryl commented Dec 3, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the community-contribution PR or Issue raised by member(s) of DataHub Community label Dec 3, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 3, 2024
maggiehays
maggiehays approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@maggiehays maggiehays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Dec 3, 2024
@jayacryl jayacryl merged commit b31d849 into master Dec 3, 2024
86 of 99 checks passed
@jayacryl jayacryl deleted the jp--fix-links branch December 3, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggiehays maggiehays maggiehays approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayacryl @maggiehays