Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datahub-client): prevent unneeded classes in datahub-client jar #12037

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix(datahub-client): prevent unneeded classes in datahub-client jar #12037

merged 2 commits into from
Dec 5, 2024

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Dec 5, 2024 •
edited
Loading

  • remove javax.servlet from datahub-client jar
  • remove swagger classes from datahub-client jar

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker
fix(datahub-client): prevent unneeded classes in datahub-client jar
4bcc2d3 
* remove java.servlet from datahub-client jar
* remove swagger classes from datahub-client jar
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Dec 5, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 5, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 5, 2024
@david-leifker david-leifker merged commit cb7d687 into datahub-project:master Dec 5, 2024
77 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@kevin1chun kevin1chun kevin1chun approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge release-0.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-leifker @kevin1chun @RyanHolstien