Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(py-sdk): DataJobPatchBuilder handling timestamps, output edges #12067

Merged
merged 5 commits into from
Dec 10, 2024
Merged

fix(py-sdk): DataJobPatchBuilder handling timestamps, output edges #12067

merged 5 commits into from
Dec 10, 2024

Conversation

shirshanka
Copy link
Contributor

@shirshanka shirshanka commented Dec 9, 2024 •
edited
Loading

Fixes a subtle bug and changes a default behavior

  • The DataJobPatchBuilder.add_output_dataset method accepted an Edge but wasn't generating the patch PATH correctly
  • Default behavior when no timestamps were provided was to mint a client side auditstamp - this unnecessarily creates updates in the aspect when that is not what the user wants.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata smoke_test Contains changes related to smoke tests labels Dec 9, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 9, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 9, 2024
asikowitz
asikowitz approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, looks like test_datajob_patch_builder needs to be updated though

@hsheth2 hsheth2 added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed pending-submitter-merge labels Dec 9, 2024
@hsheth2 hsheth2 merged commit e4ea993 into datahub-project:master Dec 10, 2024
98 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green. smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shirshanka @asikowitz @RyanHolstien @david-leifker @hsheth2