fix(openapi): fix sort criteria parameter #12090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
datahub-cyborg
bot
added
the
needs-review
| @@ -570,19 +570,15 @@ private static void addExtraParameters(final Components components) { | |||
| "SortBy" + MODEL_VERSION, | |||
| new Parameter() | |||
| .in(NAME_QUERY) | |||
| .name("sort") | |||
| .name("sortCriteria") | |||
There was a problem hiding this comment.
need a note in the release notes section for this
There was a problem hiding this comment.
Yes, the API controller still supports "sort", however client sdks using the spec will break the programmatic apis.
There was a problem hiding this comment.
It technically doesn't remove the deprecated parameter so if you were previously sending in a single string here it would not break with these changes. It only affects the documentation and OpenAPI spec. Will add a note nonetheless.
david-leifker
approved these changes
Dec 10, 2024
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist