Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: update mlflow UI #12334

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

<Typography.Title level={3}>Model Details</Typography.Title>
<InfoItemContainer justifyContent="left">
{/* TODO: should use versionProperties? */}
<InfoItem title="Version">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanHolstien should we use the versionProperties.version for this as well? are we going to deprecate the properties.version?

"""
Represents lineage information for ML entities.
"""
type MLModelLineageInfo {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if this is valid approach @shirshanka

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, just needs to have the backend mapping on the resolvers.

};

const renderTrainingJobs = () => {
const lineageTrainingJobs = model?.properties?.mlModelLineageInfo?.trainingJobs || [];
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if this is a valid approach @shirshanka

would there be any difference between pulling properties > trainingjobs or pulling relationships > trained by?

</InfoItem>
<InfoItem title="Aliases">
<InfoItemContent>
{/* use versionProperties for aliases */}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commenting this out until this get merged : #12166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants