Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/bigquery): improve profiler to support multiple partition columns #12352

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

acrylJonny
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@acrylJonny acrylJonny marked this pull request as draft January 15, 2025 13:24
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 15, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 41.04478% with 79 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/datahub/ingestion/source/bigquery_v2/profiler.py 46.15% 56 Missing ⚠️
...ub/ingestion/source/bigquery_v2/bigquery_schema.py 24.13% 22 Missing ⚠️
...ngestion/source/bigquery_v2/bigquery_schema_gen.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...ngestion/source/bigquery_v2/bigquery_schema_gen.py 79.50% <0.00%> (ø)
...ub/ingestion/source/bigquery_v2/bigquery_schema.py 64.56% <24.13%> (-2.75%) ⬇️
...c/datahub/ingestion/source/bigquery_v2/profiler.py 48.90% <46.15%> (-4.50%) ⬇️

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e46b8...9aeb0ca. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant