-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): improve docs + code clarity #12422
Conversation
# can't make this method abstract. | ||
raise NotImplementedError('sources must implement "create"') | ||
@abstractmethod | ||
def create(cls, config_dict: dict, ctx: PipelineContext) -> Self: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a concern anymore because of the added abc.update_abstractmethods(cls)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup that's the idea. but abc.update_abstractmethods was only added in python 3.10, so I might need to revert this
Adds some docs across our core interfaces and refactors some code.
Checklist