Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): improve docs + code clarity #12422

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat(sdk): improve docs + code clarity #12422

merged 5 commits into from
Jan 23, 2025

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 21, 2025

Adds some docs across our core interfaces and refactors some code.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 21, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-ingestion/src/datahub/utilities/urns/_urn_base.py 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...data-ingestion/src/datahub/emitter/enum_helpers.py 100.00% <100.00%> (ø)
...adata-ingestion/src/datahub/emitter/mce_builder.py 81.77% <ø> (ø)
...-ingestion/src/datahub/ingestion/api/decorators.py 98.18% <ø> (ø)
...tadata-ingestion/src/datahub/ingestion/api/sink.py 97.33% <ø> (ø)
...data-ingestion/src/datahub/ingestion/api/source.py 99.15% <ø> (ø)
...-ingestion/src/datahub/utilities/urns/_urn_base.py 85.11% <80.00%> (-0.34%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e23c5...f0cbecf. Read the comment docs.

# can't make this method abstract.
raise NotImplementedError('sources must implement "create"')
@abstractmethod
def create(cls, config_dict: dict, ctx: PipelineContext) -> Self: ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a concern anymore because of the added abc.update_abstractmethods(cls) ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup that's the idea. but abc.update_abstractmethods was only added in python 3.10, so I might need to revert this

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 22, 2025
@hsheth2 hsheth2 merged commit 5309ae0 into master Jan 23, 2025
188 of 190 checks passed
@hsheth2 hsheth2 deleted the sdk-improvements branch January 23, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants