Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 🐳 - Allow to store Quickstart dockers data in a folder for persistance #1568

Merged
merged 4 commits into from
Mar 23, 2020

Conversation

afranzi
Copy link
Contributor

@afranzi afranzi commented Feb 20, 2020

This PR aims to allow to modify the docker-compose file allowing us to specify a data folder for storing the data from MySQL, Elastic, Neo4j and Zookeeper.

It's adding two new components (kafka-rest-proxy & kafka-topics-ui) so it's easier to debug the kafka integration.

And modified the Broker host to use $HOSTNAME, so in case of deploying the quickstart solution in an EC2 instance, it's easier to access the broker from outside.

@mars-lan mars-lan requested a review from keremsahin1 February 20, 2020 15:10
docker/quickstart/docker-compose.yml Show resolved Hide resolved
docker/quickstart/docker-compose.yml Outdated Show resolved Hide resolved
docker/quickstart/docker-compose.yml Show resolved Hide resolved
docker/quickstart/docker-compose.yml Show resolved Hide resolved
@afranzi afranzi closed this Feb 21, 2020
@afranzi afranzi deleted the DAT-510/quickstart-docker branch February 21, 2020 08:29
@afranzi afranzi restored the DAT-510/quickstart-docker branch February 21, 2020 08:55
@afranzi afranzi reopened this Feb 21, 2020
@mars-lan
Copy link
Contributor

Are we ready to merge this in @keremsahin1?

@afranzi
Copy link
Contributor Author

afranzi commented Mar 10, 2020

I will try to provide the quickstart.sh script that @keremsahin1 requested today.

@mars-lan mars-lan added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Mar 18, 2020
@mars-lan
Copy link
Contributor

Ping @afranzi? Would really love to get your awesome changes in.

@afranzi
Copy link
Contributor Author

afranzi commented Mar 23, 2020

My fault, busy days.

@keremsahin1 keremsahin1 merged commit 5ac098f into datahub-project:master Mar 23, 2020
@mars-lan
Copy link
Contributor

mars-lan commented Apr 2, 2020

Actually I start getting the following error in elasticsearch docker after this PR

elasticsearch           | [2020-04-02T13:53:43,546][WARN ][o.e.b.ElasticsearchUncaughtExceptionHandler] [] uncaught exception in thread [main]
elasticsearch           | org.elasticsearch.bootstrap.StartupException: java.lang.IllegalStateException: Failed to create node environment
elasticsearch           | 	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:136) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:123) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:70) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:134) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.cli.Command.main(Command.java:90) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:91) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:84) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | Caused by: java.lang.IllegalStateException: Failed to create node environment
elasticsearch           | 	at org.elasticsearch.node.Node.<init>(Node.java:268) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.node.Node.<init>(Node.java:245) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:233) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:233) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:342) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:132) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	... 6 more
elasticsearch           | Caused by: java.nio.file.AccessDeniedException: /usr/share/elasticsearch/data/nodes
elasticsearch           | 	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:84) ~[?:?]
elasticsearch           | 	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) ~[?:?]
elasticsearch           | 	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) ~[?:?]
elasticsearch           | 	at sun.nio.fs.UnixFileSystemProvider.createDirectory(UnixFileSystemProvider.java:384) ~[?:?]
elasticsearch           | 	at java.nio.file.Files.createDirectory(Files.java:674) ~[?:1.8.0_161]
elasticsearch           | 	at java.nio.file.Files.createAndCheckIsDirectory(Files.java:781) ~[?:1.8.0_161]
elasticsearch           | 	at java.nio.file.Files.createDirectories(Files.java:767) ~[?:1.8.0_161]
elasticsearch           | 	at org.elasticsearch.env.NodeEnvironment.<init>(NodeEnvironment.java:221) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.node.Node.<init>(Node.java:265) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.node.Node.<init>(Node.java:245) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:233) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:233) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:342) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:132) ~[elasticsearch-5.6.8.jar:5.6.8]
elasticsearch           | 	... 6 more

Seem likes the chown 1000:1000 ${DATA_STORAGE_FOLDER}/elasticsearch trick didn't resolve the permission issue. Did you test it on Linux or Mac, @afranzi ?

@afranzi
Copy link
Contributor Author

afranzi commented Apr 2, 2020

I've tested on Linux

@mars-lan
Copy link
Contributor

mars-lan commented Apr 2, 2020

I see. I'm having this issue on Mac. Let me test it on Linux.

@mars-lan
Copy link
Contributor

mars-lan commented Apr 2, 2020

The Mac issue is fixed in #1621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants