Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused legacy model & move DatasetSearchConfig #1618

Merged
merged 1 commit into from
Apr 1, 2020
Merged

refactor: remove unused legacy model & move DatasetSearchConfig #1618

merged 1 commit into from
Apr 1, 2020

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Apr 1, 2020

  • Remove LineageType, which has long been replaced by DatasetLineageType and has no material use in code
  • Move DatasetSearchConfig to the same location as other search-related configs

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

jywadhwani
jywadhwani approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@jywadhwani jywadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mars-lan mars-lan merged commit df325ec into datahub-project:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywadhwani jywadhwani jywadhwani approved these changes

@keremsahin1 keremsahin1 Awaiting requested review from keremsahin1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mars-lan @jywadhwani