Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Converting MCE to a Spring boot Application #1629

Merged
merged 10 commits into from
Apr 6, 2020
Merged

feat: Converting MCE to a Spring boot Application #1629

merged 10 commits into from
Apr 6, 2020

Conversation

arunvasudevan
Copy link
Collaborator

@arunvasudevan arunvasudevan commented Apr 4, 2020 •
edited
Loading

Checklist

@arunvasudevan
Copy link
Collaborator Author

Closes #1628

@arunvasudevan
Copy link
Collaborator Author

arunvasudevan commented Apr 5, 2020 •
edited
Loading

Running quickstart on the current master throws ping: kafka-setup: Name or service not known for mae-consumer and mce-consumer
Fixed it as part of this commit - 45ad848

keremsahin1
keremsahin1 approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@keremsahin1 keremsahin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect! I assume you plan to do the same for MAE consumer?

mars-lan
mars-lan suggested changes Apr 5, 2020
View reviewed changes
docker/quickstart/docker-compose.yml Outdated Show resolved Hide resolved
@arunvasudevan
Copy link
Collaborator Author

Yes @keremsahin1 I will do the same for MAE once this is approved.

mars-lan
mars-lan approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the contribution.

@mars-lan
Copy link
Contributor

mars-lan commented Apr 6, 2020

Will merge after CI passes

@mars-lan mars-lan merged commit e56e4ea into datahub-project:master Apr 6, 2020
@arunvasudevan arunvasudevan deleted the mce_springboot branch April 6, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keremsahin1 keremsahin1 keremsahin1 approved these changes

@mars-lan mars-lan mars-lan approved these changes

@jywadhwani jywadhwani Awaiting requested review from jywadhwani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunvasudevan @mars-lan @keremsahin1