Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(urn): Move UrnCoercer into corresponding Urn class #1661

Merged
merged 1 commit into from
May 7, 2020
Merged

fix(urn): Move UrnCoercer into corresponding Urn class #1661

merged 1 commit into from
May 7, 2020

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented May 7, 2020 •
edited
Loading

This fixs #1654
Also throw the real cause in the case of reflection invocation

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@mars-lan
fix(urn): Move UrnCoercer into corresponding Urn class
e63c596 
This fix datahub-project#1654
Also throw the real cause in the case of reflection invocation
@mars-lan mars-lan requested a review from keremsahin1 May 7, 2020 19:21
@mars-lan mars-lan merged commit 653f6cb into datahub-project:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keremsahin1 keremsahin1 keremsahin1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mars-lan @keremsahin1