Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pdl): convert all pdsc to pdl #1678

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

mars-lan
Copy link
Contributor

Use the automated tool in https://linkedin.github.io/rest.li/pdl_migration
Also update all relevant docs

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jywadhwani
Copy link
Contributor

There are some more md files that reference the PDSC models https://github.com/linkedin/datahub/search?p=1&q=pdsc&unscoped_q=pdsc
We can include them in this commit, or address them in the next one.

@jywadhwani
Copy link
Contributor

Looks like you just pushed another commit that addresses my comment :)

@mars-lan
Copy link
Contributor Author

Yeah did a more thorough search after my initial commit. Maybe we should cut a 0.3.2 release before making this big change @jywadhwani?

@jywadhwani
Copy link
Contributor

The original plan was to cut release 0.3.2 and then include PDL changes. We might have to wait till sometime next week for 0.3.2 release to be out (before the town hall) - I will leave it to you to decide whether to push this change now @mars-lan.

Use the automated tool in https://linkedin.github.io/rest.li/pdl_migration
Also update all relevant docs
@mars-lan
Copy link
Contributor Author

Is there any additional changes planned for 0.3.2? If not, I push first this and let you cut a release based off the preceding commit next week?

@jywadhwani
Copy link
Contributor

No additional changes needed for 0.3.2. We can cut a release next week based off the preceding commit. You can ship this one!

@mars-lan mars-lan merged commit 1283dd3 into datahub-project:master May 21, 2020
chriscollins3456 added a commit to chriscollins3456/datahub that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants