Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docker): refactor ingestion docker build script #1690

Merged
merged 1 commit into from
Jun 5, 2020
Merged

build(docker): refactor ingestion docker build script #1690

merged 1 commit into from
Jun 5, 2020

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Jun 4, 2020

  • add "build" option to docker-compose file to simplify rebuilding of images
  • move command from docker-compose.yml to Dockerfile
  • add ingestion.sh script to simplify quickstart instruction and to reduce confusion

Fix #1689

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

keremsahin1
keremsahin1 reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@keremsahin1 keremsahin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of the command in docker-compose.yml now that we have it in Dockerfile?
(Interestingly Github didn't allow me to add this comment on that specific line, so adding it as a general comment)

@mars-lan
build(docker): refactor ingestion docker build script
d56768e 
- add "build" option to docker-compose file to simplify rebuilding of images
- move command from docker-compose.yml to Dockerfile
- add ingestion.sh script to simplify quickstart instruction and to reduce confusion
@mars-lan
Copy link
Contributor Author

mars-lan commented Jun 5, 2020

We can get rid of the command in docker-compose.yml now that we have it in Dockerfile?
(Interestingly Github didn't allow me to add this comment on that specific line, so adding it as a general comment)

Done

@mars-lan mars-lan merged commit 94ffb30 into datahub-project:master Jun 5, 2020
mars-lan added a commit to mars-lan/datahub that referenced this pull request Jun 25, 2020
@mars-lan
build(docker): refactor ingestion docker build script (datahub-projec…
deaecdd 
…t#1690)

- add "build" option to docker-compose file to simplify rebuilding of images
- move command from docker-compose.yml to Dockerfile
- add ingestion.sh script to simplify quickstart instruction and to reduce confusion
chriscollins3456 pushed a commit to chriscollins3456/datahub that referenced this pull request Sep 14, 2023
@iprentic
feat(domains): Do not allow deleting a domain with child domains (dat…
d2d5584 
…ahub-project#1690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keremsahin1 keremsahin1 keremsahin1 approved these changes

@RealChrisL RealChrisL Awaiting requested review from RealChrisL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The quickstart script ends in a different folder than it started
2 participants
@mars-lan @keremsahin1