-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(business-glossary):RFC for Business Glossary #1842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmsrao
changed the title
RFC for Business Glossary
feat(business-glossary):RFC for Business Glossary
Sep 1, 2020
mars-lan
added
the
rfc
See https://github.com/linkedin/datahub/blob/master/docs/rfc.md for more details
label
Sep 1, 2020
Hi Nagarjuna
I agree with you on having the Dataset field having URN (heard this from you during the Townhall). Regarding making the Dataset Field as first class citizen/entity, I believe you guys know better . Just wanted to check on what will be the overhead on making Dataset fields as first class entity (with respect to performance/storage), will there be any downside in making field as first class entity
Also wanted to check having URN and making first class entity are related?
Regards
Madhu
|
HI Nagarjuna
Thanks for clarifying and make sense to have as first class entity.
Do let me know any specific changes to be done to the RFC content?
Regards
Madhu
|
updated the attribute of Business Term
mars-lan
reviewed
Sep 29, 2020
updated the alternatives section
incorporated the feedback provided by Nagarjuna
nagarjunakanamarlapudi
suggested changes
Oct 11, 2020
Incorporated feedback a) removal of redundant uri attribute from BusinessTerm definition b) rolled back changes to SchemaField (as per feedback) and will continue to use fieldPath is unique identified for a field in a given Dataset
nagarjunakanamarlapudi
suggested changes
Oct 14, 2020
incorporated the feedback |
nagarjunakanamarlapudi
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me
I will give one more week for others to review, else will merge this on 11/04. |
Please also announce on #rfc to solicit comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Business Glossary is one of the important aspect in Metadata, which brings common vocabulary to the data elements in the organisation. Came up with initial thoughts on how one can visualise the Business Glossary in the Data Catalog
Checklist