Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(business-glossary):RFC for Business Glossary #1842

Merged
merged 14 commits into from
Nov 5, 2020

Conversation

pmsrao
Copy link
Contributor

@pmsrao pmsrao commented Sep 1, 2020

Business Glossary is one of the important aspect in Metadata, which brings common vocabulary to the data elements in the organisation. Came up with initial thoughts on how one can visualise the Business Glossary in the Data Catalog

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@pmsrao pmsrao changed the title RFC for Business Glossary feat(business-glossary):RFC for Business Glossary Sep 1, 2020
@mars-lan mars-lan added the rfc See https://github.com/linkedin/datahub/blob/master/docs/rfc.md for more details label Sep 1, 2020
@mars-lan
Copy link
Contributor

mars-lan commented Sep 1, 2020

@pmsrao
Copy link
Contributor Author

pmsrao commented Sep 1, 2020 via email

@pmsrao
Copy link
Contributor Author

pmsrao commented Sep 1, 2020 via email

updated the attribute of Business Term
updated the alternatives section
docs/rfc/active/business_glossary/README.md Outdated Show resolved Hide resolved
docs/rfc/active/business_glossary/README.md Outdated Show resolved Hide resolved
docs/rfc/active/business_glossary/README.md Outdated Show resolved Hide resolved
docs/rfc/active/business_glossary/README.md Outdated Show resolved Hide resolved
incorporated the feedback provided by Nagarjuna
docs/rfc/active/business_glossary/README.md Outdated Show resolved Hide resolved
docs/rfc/active/business_glossary/README.md Show resolved Hide resolved
docs/rfc/active/business_glossary/README.md Outdated Show resolved Hide resolved
docs/rfc/active/business_glossary/README.md Outdated Show resolved Hide resolved
docs/rfc/active/business_glossary/README.md Outdated Show resolved Hide resolved
Incorporated feedback 
a) removal of redundant uri attribute from BusinessTerm definition
b) rolled back changes to SchemaField (as per feedback) and will continue to use fieldPath is unique identified for a field in a given Dataset
@pmsrao
Copy link
Contributor Author

pmsrao commented Oct 14, 2020

incorporated the feedback

Copy link
Contributor

@nagarjunakanamarlapudi nagarjunakanamarlapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@nagarjunakanamarlapudi
Copy link
Contributor

nagarjunakanamarlapudi commented Oct 28, 2020

I will give one more week for others to review, else will merge this on 11/04.

@mars-lan
Copy link
Contributor

I will give one more week for others to review, else will merge this on 11/04.

Please also announce on #rfc to solicit comments

@nagarjunakanamarlapudi nagarjunakanamarlapudi merged commit 0527e48 into datahub-project:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc See https://github.com/linkedin/datahub/blob/master/docs/rfc.md for more details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants