Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Module consolidation for some test modules and reduces errors from unsupported API calls #1844

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

cptran777
Copy link
Contributor

This PR reflects recent work taking place internally. It consolidates some of the testing modules for the frontend, which should help improve build times and create a more manageable testing suite. It also resolves some issues raised by the open source community in response to recent changes. There are also some "behind-the-scenes" kind of changes going in that help us resolve some challenges in creating a smooth, semi-automated pipeline between internal and open source development in order to rollout changes more quickly.

Issues resolved:

Testing Done:

gradlew build successful
BUILD SUCCESSFUL in 11m 36s
227 actionable tasks: 227 executed

Ran docker images and tested changes to ensure that application builds and behaves as expected

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cptran777 cptran777 merged commit c2c6f66 into master Sep 3, 2020
@cptran777 cptran777 deleted the update-datahub-web branch September 3, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants