-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Port mce-cli to Java. #1871
Conversation
Also moved off the avro format event file to json instead. Much nicer to use :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to update the ingestion docker image using this?
@keremsahin1 what is that docker image meant to do? It isn't clear to me nor really documented. Just run the ingestion script from docker rather than your machine? |
It's for populating mock data in quickstart: https://github.com/linkedin/datahub/blob/master/docs/quickstart.md. Removing the need to setting up the correct runtime environment (Python before, Java now). |
Done |
Done, need approval? Seems like I can't mark single comments as resolved. May always be better to "start a review", even with single comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Also moved off the avro format event file to json instead. Much nicer to use :)
#1743
Checklist