Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Port mce-cli to Java. #1871

Merged
merged 4 commits into from
Sep 25, 2020
Merged

feat: Port mce-cli to Java. #1871

merged 4 commits into from
Sep 25, 2020

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Sep 11, 2020

Also moved off the avro format event file to json instead. Much nicer to use :)

#1743

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Also moved off the avro format event file to json instead. Much nicer to use :)
@jplaisted jplaisted requested a review from mars-lan September 11, 2020 20:35
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update the ingestion docker image using this?

@jplaisted
Copy link
Contributor Author

@keremsahin1 what is that docker image meant to do? It isn't clear to me nor really documented. Just run the ingestion script from docker rather than your machine?

@mars-lan
Copy link
Contributor

mars-lan commented Sep 14, 2020

@keremsahin1 what is that docker image meant to do? It isn't clear to me nor really documented. Just run the ingestion script from docker rather than your machine?

It's for populating mock data in quickstart: https://github.com/linkedin/datahub/blob/master/docs/quickstart.md. Removing the need to setting up the correct runtime environment (Python before, Java now).

@jplaisted
Copy link
Contributor Author

Done

@jplaisted
Copy link
Contributor Author

Also need to update the ingestion docker image using this?

Done, need approval? Seems like I can't mark single comments as resolved. May always be better to "start a review", even with single comments.

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jplaisted jplaisted merged commit 821bce7 into datahub-project:master Sep 25, 2020
@jplaisted jplaisted deleted the javaCli branch September 25, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants