Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new spring factories to customize metadata event topic names. #1894

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add new spring factories to customize metadata event topic names. #1894

merged 1 commit into from
Sep 29, 2020

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Sep 25, 2020

New env vars:

  • METADATA_CHANGE_EVENT_NAME: The name of the metadata change event topic.
  • METADATA_AUDIT_EVENT_NAME: The name of the metadata audit event topic.
  • FAILED_METADATA_CHANGE_EVENT_NAME: The name of the failed metadata change event topic.

This will need to be consistent throughout your ecosystem.

CLOSES: #1840

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

New env vars:

- METADATA_CHANGE_EVENT_NAME: The name of the metadata change event topic.
- METADATA_AUDIT_EVENT_NAME: The name of the metadata audit event topic.
- FAILED_METADATA_CHANGE_EVENT_NAME: The name of the failed metadata change event topic.

This will need to be consistent throughout your ecosystem.

CLOSES: #1840
@jplaisted jplaisted marked this pull request as ready for review September 28, 2020 21:19
@jplaisted jplaisted merged commit 54eee3e into datahub-project:master Sep 29, 2020
@hseksaria
Copy link

Thank you John, Mars and Team :). This was much needed.

@mars-lan
Copy link
Contributor

mars-lan commented Oct 1, 2020

@jplaisted could you also update all relevant docs to make it more obvious?

@jplaisted jplaisted deleted the kafkaTopicNames branch February 26, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable kafka topic names.
3 participants