Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): Dashboard models update #1932

Merged
merged 3 commits into from
Nov 12, 2020
Merged

feat(dashboard): Dashboard models update #1932

merged 3 commits into from
Nov 12, 2020

Conversation

keremsahin1
Copy link
Contributor

@keremsahin1 keremsahin1 commented Oct 9, 2020 •
edited
Loading

Changes in this PR are as below:

  • Adding rest.li API models & resource key models
  • Make ChartQueryType a separate model instead of an inline model
  • Add Chart & Dashboard snapshots to Snapshot.pdl
  • Make fields in chart & dashboard search document models strongly typed by using enum models instead of primitive types (we support enums in search document models)
  • Remove fields which help to find relationships between dataset-chart-dashboard from search document models because we ideally surface relationships and serve relationship queries through graph not search
  • Add chartUrl and dashboardUrl into chartInfo & dashboardInfo aspects

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@keremsahin1 keremsahin1 added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 9, 2020
@keremsahin1 keremsahin1 self-assigned this Oct 9, 2020
@keremsahin1 keremsahin1 mentioned this pull request Oct 9, 2020
Merged
4 tasks
@keremsahin1 keremsahin1 force-pushed the dashboard_model_update branch 2 times, most recently from 97b4349 to 009fdac Compare October 27, 2020 02:54
@keremsahin1 keremsahin1 force-pushed the dashboard_model_update branch 4 times, most recently from ac73d79 to 1b4d274 Compare November 3, 2020 00:51
@keremsahin1 keremsahin1 force-pushed the dashboard_model_update branch from 1b4d274 to 4ff954d Compare November 12, 2020 02:53
mars-lan
mars-lan approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@keremsahin1 keremsahin1 merged commit 733893f into datahub-project:master Nov 12, 2020
@keremsahin1 keremsahin1 deleted the dashboard_model_update branch November 18, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantatspothero grantatspothero grantatspothero left review comments

@shirshanka shirshanka shirshanka left review comments

@mars-lan mars-lan mars-lan approved these changes

@jplaisted jplaisted Awaiting requested review from jplaisted

@hshahoss hshahoss Awaiting requested review from hshahoss

Assignees

@keremsahin1 keremsahin1

Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keremsahin1 @shirshanka @mars-lan @grantatspothero @hshahoss