Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct search over new field docs #1934

Merged
merged 1 commit into from
Oct 10, 2020
Merged

docs: correct search over new field docs #1934

merged 1 commit into from
Oct 10, 2020

Conversation

shubhamg931
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shubhamg931
shubhamg931 commented Oct 10, 2020
View reviewed changes
docs/how/search-over-new-field.md
@@ -256,7 +256,7 @@ curl 'http://localhost:8080/corpUsers?action=ingest' -X POST -H 'X-RestLi-Protoc
Once the ingestion is done, you can test your changes by issuing search queries. Here is an example query with response.

```sh
curl "http://localhost:8080/corpUsers?q=search&input=ai200" -H 'X-RestLi-Protocol-Version: 2.0.0' -s | jq
curl "http://localhost:8080/corpUsers?q=search&input=ai100" -H 'X-RestLi-Protocol-Version: 2.0.0' -s | jq
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The course name being ingested as data during ingestion is AI100: Introduction to Artificial Intelligence

Searching ai200 gives empty results.

mars-lan
mars-lan approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the doc!

@mars-lan mars-lan added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 10, 2020
@mars-lan mars-lan merged commit 9b63d50 into datahub-project:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars-lan mars-lan mars-lan approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhamg931 @mars-lan