Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Ownership avatar fix and aspect fetching improvement #1935

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

cptran777
Copy link
Contributor

Changes:

  • Broken links on User Avatar #1923 Fixes issue where user avatar reaches internal page, and now instead will reach the user profile page
  • Incoporates @igbopie 's internal improvements made to aspect fetching from the UI. This is a work in progress

Testing done:

Manually tested by building the docker images and applying these changes to ensure that application still builds and runs as expected. Navigated successfully from the dataset owners to the profile page

Since this fix is a patchwork until refactoring the avatar components altogether, will rely on the above testing and automated tests as part of the github build.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cptran777 cptran777 added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 12, 2020
@cptran777 cptran777 merged commit 226a3ab into master Oct 13, 2020
@cptran777 cptran777 deleted the fix-user-avatars-and-aspects branch October 13, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant