refactor: store urns parts in search index builder efficiently #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mars-lan
added
the
hacktoberfest-accepted
keremsahin1
reviewed
Oct 14, 2020
...ta-builders/src/main/java/com/linkedin/metadata/builders/search/DataProcessIndexBuilder.java
Show resolved
Hide resolved
metadata-builders/src/main/java/com/linkedin/metadata/builders/search/DatasetIndexBuilder.java
Outdated
Show resolved
Hide resolved
jywadhwani
force-pushed
the
refactor_builder
branch
from
da362b1 to
5e1efd8
Compare
keremsahin1
approved these changes
Oct 14, 2020
|
FYI seems like this ended up not setting the urn for most documents, causing the MAE processor to fail. |
|
This also indicates our tests here are lacking. |
4 tasks
jplaisted
pushed a commit
that referenced
this pull request
Oct 28, 2020
4 tasks
jywadhwani
added a commit
to jywadhwani/datahub
that referenced
this pull request
Oct 28, 2020
jywadhwani
added a commit
to jywadhwani/datahub
that referenced
this pull request
Oct 28, 2020
…-project#1937) Co-authored-by: Jyoti Wadhwani <[email protected]>
jplaisted
pushed a commit
that referenced
this pull request
Oct 28, 2020
The other index builders need similar improvements, but after #1937 some coverage is better than no coverage.
jywadhwani
added a commit
to jywadhwani/datahub
that referenced
this pull request
Oct 28, 2020
…-project#1937) Co-authored-by: Jyoti Wadhwani <[email protected]>
jywadhwani
added a commit
that referenced
this pull request
Oct 29, 2020
…1972) * refactor search index builder to store urn parts efficiently (#1937) Co-authored-by: Jyoti Wadhwani <[email protected]> * set urn for all documents * rebase, fix merge conflicts and modify tests Co-authored-by: Jyoti Wadhwani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist