Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): internal catchup - module consolidations for faster build times #1947

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

cptran777
Copy link
Contributor

@cptran777 cptran777 commented Oct 19, 2020

Minor catchup PR for internal module consolidations from @igbopie to improve build times.

Testing done

Build and run docker images with changes to ensure that application builds and behaves as expected.
Will rely on automated tests as part of PR process to ensure that other cases have not changed.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cptran777 cptran777 added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 19, 2020
@cptran777 cptran777 requested a review from igbopie October 19, 2020 19:29
@cptran777
Copy link
Contributor Author

Oh and we're all in on eyeglass now

@cptran777 cptran777 merged commit 4a80baa into master Oct 20, 2020
@cptran777 cptran777 deleted the fe-catchup-10-19-20 branch October 20, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant