fix: validate entity type for an urn #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars-lan
suggested changes
Oct 23, 2020
Done |
mars-lan
approved these changes
Oct 23, 2020
mars-lan
added
the
hacktoberfest-accepted
|
Hey this just blocked us from moving to the new repo. Can we revert this and make the change there instead? |
|
Yeah we can roll this back and cherrypick the change to datahub-gma |
jplaisted
pushed a commit
that referenced
this pull request
Oct 23, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no consistent way of validating the type of an urn. This changes attempts to fix it.
Checklist