Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade Neo4j to 4.0 #1960

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

keremsahin1
Copy link
Contributor

LinkedIn internally migrated to Neo4j 4.0. To better serve OSS, it's better to upgrade Neo4j to 4.0 here as well. The Java clients are already on 4.0 and they are compatible with 3.5 and 4.0. In this change, only Neo4j server is being upgraded from 3.5 to 4.0. If a user already has a Neo4j docker volume with a graph db created with Neo4j 3.5, with this change, that will be auto upgraded to 4.0 without any extra work.

Tests

Test1: In-place DB upgrade 3.5 -> 4.0

  1. Run ./docker/dev.sh without this diff (Neo4j 3.5 running).
  2. Run ./docker/ingestion/ingestion.sh to ingest sample data.
  3. Stopped all containers.
  4. Run ./docker/dev.sh with this diff (Neo4j 4.0 running).
  5. Did tests using Neo4j browser and also confirmed that relationship tab for datasets (served by graph) is working as expected.

Test2: 4.0

  1. Removed all Docker containers, volumes and networks.
  2. Run ./docker/dev.sh with this diff (Neo4j 4.0 running).
  3. Run ./docker/ingestion/ingestion.sh to ingest sample data.
  4. Did tests using Neo4j browser and also confirmed that relationship tab for datasets (served by graph) is working as expected.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@keremsahin1 keremsahin1 added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2020
@mars-lan mars-lan changed the title Upgrade Neo4j to 4.0 feat: upgrade Neo4j to 4.0 Oct 26, 2020
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mars-lan mars-lan merged commit b989f9d into datahub-project:master Oct 26, 2020
@camelliazhang
Copy link
Contributor

Good job! 💯

@keremsahin1 keremsahin1 deleted the neo4j-upgrade branch October 26, 2020 23:24
@keremsahin1 keremsahin1 mentioned this pull request Nov 16, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants