[Breaking] Update to GMA 0.2.0 and fix Urn definitions. #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urn definitions needed to be updated since 0.2.0 changed the base Urn class. But while I was here also changed "fieldNameEntity" to just "fieldName" for many fields in many urns. I don't know why these fields had different names than the urn definition (extra "entity" suffix), but I figured I'd fix that while I was here. I also added some more urn coercers that were missing.
Looking internally, we have both methods. But the non-entity versions are deprecated. I'm not sure why. But let's be consistent.
mars-lan
added
the
hacktoberfest-accepted
jywadhwani
suggested changes
Nov 3, 2020
li-utils/src/main/javaPegasus/com/linkedin/common/urn/AzkabanJobUrn.java
Show resolved
Hide resolved
jywadhwani
reviewed
Nov 3, 2020
li-utils/src/main/javaPegasus/com/linkedin/common/urn/CorpGroupUrn.java
Outdated
Show resolved
Hide resolved
jywadhwani
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urn definitions needed to be updated since 0.2.0 changed the base Urn class.
I also added some more urn coercers that were missing.
Checklist