Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SCSI bootstrap script for datasets #1978

Merged
merged 1 commit into from
Nov 3, 2020
Merged

feat: add SCSI bootstrap script for datasets #1978

merged 1 commit into from
Nov 3, 2020

Conversation

jywadhwani
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

mars-lan
mars-lan reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better location might be https://github.com/linkedin/datahub-gma/tree/master/dao-impl/ebean-dao

@mars-lan mars-lan added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2020
@keremsahin1
Copy link
Contributor

A better location might be https://github.com/linkedin/datahub-gma/tree/master/dao-impl/ebean-dao

This script is entity specific. I don't think we would want to move entity specific stuff into datahub-gma.

@mars-lan
Copy link
Contributor

mars-lan commented Nov 1, 2020

A better location might be https://github.com/linkedin/datahub-gma/tree/master/dao-impl/ebean-dao

This script is entity specific. I don't think we would want to move entity specific stuff into datahub-gma.

Argh that makes sense. nvm.

@jywadhwani jywadhwani merged commit 2f47978 into datahub-project:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars-lan mars-lan mars-lan left review comments

@nagarjunakanamarlapudi nagarjunakanamarlapudi nagarjunakanamarlapudi left review comments

@keremsahin1 keremsahin1 keremsahin1 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jywadhwani @keremsahin1 @mars-lan @nagarjunakanamarlapudi