Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GMA to latest #2007

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Bump GMA to latest #2007

merged 1 commit into from
Nov 18, 2020

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Nov 18, 2020 •
edited
Loading

Involves fixing some types. Bright side is that ModelValidation actually checks aspects now (it did not before because aspects are not records but unions!).

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Bump GMA to latest
7cb62c6 
Involves fixing some types. Bright side is that ModelValidation actually checks aspects now (it did not before because aspects are not records but unions!).
@jplaisted jplaisted requested a review from jywadhwani November 18, 2020 20:54
jywadhwani
jywadhwani approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jywadhwani jywadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes

@jplaisted jplaisted merged commit 6f59a91 into datahub-project:master Nov 18, 2020
@jplaisted jplaisted deleted the update branch November 18, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywadhwani jywadhwani jywadhwani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplaisted @jywadhwani