Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(React Incubation): adding lineage page with sample data #2090

Merged
merged 2 commits into from
Feb 8, 2021
Merged

feat(React Incubation): adding lineage page with sample data #2090

merged 2 commits into from
Feb 8, 2021

Conversation

gabe-lyons
Copy link
Contributor

@gabe-lyons gabe-lyons commented Feb 8, 2021 •
edited by shirshanka
Loading

Upcoming: wire this into the graphql endpoint

Screen Shot 2021-02-08 at 12 07 27 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@gabe-lyons gabe-lyons changed the title feat(React Inbucation): adding lineage page with sample data feat(React Incubation): adding lineage page with sample data Feb 8, 2021
shirshanka
shirshanka approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 99e0a11 into datahub-project:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabe-lyons @shirshanka