Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(React): Adding schema tab on dataset entity #2096

Merged
merged 1 commit into from
Feb 10, 2021
Merged

feat(React): Adding schema tab on dataset entity #2096

merged 1 commit into from
Feb 10, 2021

Conversation

gabe-lyons
Copy link
Contributor

Adding the schema tab using prod data. Viewable here:

image

This change includes visual support for tags, although tag support in the BE is still a WIP.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@gabe-lyons
Copy link
Contributor Author

One note: this pr removes package-lock.json. This is intentional- it was inadvertently committed.

shirshanka
shirshanka approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice @gabe-lyons!

@shirshanka shirshanka merged commit c2698b9 into datahub-project:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabe-lyons @shirshanka