feat(React): Deprecation status in dataset header #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
force-pushed
the
ReactDeprecationStatusOnHeader
branch
2 times, most recently
from
8a784c7 to
fe18154
Compare
gabe-lyons
force-pushed
the
ReactDeprecationStatusOnHeader
branch
from
fe18154 to
96a8f23
Compare
jjoyce0510
reviewed
Feb 10, 2021
| @@ -5,7 +5,7 @@ import { RoutedTabs } from './RoutedTabs'; | |||
| export interface EntityProfileProps { | |||
| title: string; | |||
| tags?: Array<string>; | |||
| body: React.ReactNode; | |||
| header: React.ReactNode; | |||
jjoyce0510
approved these changes
Feb 10, 2021
jjoyce0510
reviewed
Feb 10, 2021
| placement="bottomLeft" | ||
| content={ | ||
| <> | ||
| <Typography.Paragraph>By: {deprecation?.actor}</Typography.Paragraph> |
There was a problem hiding this comment.
Nit: Maybe not need for the ":" here. It would also be useful to add a link
jjoyce0510
reviewed
Feb 10, 2021
| <Typography.Paragraph>By: {deprecation?.actor}</Typography.Paragraph> | ||
| {deprecation.decommissionTime && ( | ||
| <Typography.Paragraph> | ||
| On: {new Date(deprecation?.decommissionTime).toUTCString()} |
There was a problem hiding this comment.
Same here with the ":"
There was a problem hiding this comment.
Great points- let's do those in followups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is read-only currently. When hovered it displays additional details.
Closeup of the module, when hovered over:
Checklist