feat(React): Avatar dropdown menu and logout function #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabe-lyons @jjoyce0510 @shirshanka |
gabe-lyons
reviewed
Feb 18, 2021
Comment on lines
41
to
43
| if (!isLoggedIn) { | ||
| return <Redirect to="/login" />; | ||
| } |
There was a problem hiding this comment.
do you need this redirect? Each page is wrapped in a ProtectedRoute component which should be doing this redirect for you
There was a problem hiding this comment.
You are right, this is removed now.
gabe-lyons
reviewed
Feb 18, 2021
| /> | ||
| </Link> | ||
| <Dropdown overlay={menu}> | ||
| <Link to={`/${entityRegistry.getPathName(EntityType.CorpUser)}/${_urn}`}> |
gabe-lyons
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
looks great, thanks @brendansun. I do think you may be able to remove the redirect logic though.
gabe-lyons
reviewed
Feb 18, 2021
| const isLoggedIn = checkAuthStatus(); | ||
|
|
||
| const handleLogout = () => { | ||
| Cookies.remove('PLAY_SESSION'); |
There was a problem hiding this comment.
technically, this line isn't doing anything. the play cookie is http only, so js isn't able to read or write it
There was a problem hiding this comment.
This line is removed now.
|
@gabe-lyons Comments resolved, please review again. Thanks! |
shirshanka
approved these changes
Feb 18, 2021
|
Thanks Brendan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This PR changes all page that includes the header bar.
Changes
This PR adds new feature which pops up a menu when hovering on profile on top right corner of the page. Currently, there is only 1 option, that is to log out. After this option is clicked, user session is cleared and users are redirected to the login page.
This PR also contains a overwritten changes in #2095 where multiple clicking on the profile will redirect users to url like "user/user/user/user/..."
Checklist