Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(React): Adding test coverage for search page & fixing filter select bug #2131

Merged

Conversation

gabe-lyons
Copy link
Contributor

@gabe-lyons gabe-lyons commented Feb 23, 2021

This PR

Introduces tests for search facet filtering
Fixes mock search data so it can be used properly with tests, and enforcing that it will stay correct in the future
Fixes bug where selecting multiple filters provides a broken UI experience.
Fixes key warnings across other tests

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 4dcbef6 into datahub-project:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants