Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: neo4j Bolt TLS support (#2100) #2145

Merged
merged 1 commit into from
Mar 1, 2021
Merged

feat: neo4j Bolt TLS support (#2100) #2145

merged 1 commit into from
Mar 1, 2021

Conversation

RickardCardell
Copy link
Contributor 

Bumping version of neo4j-java-driver to include encryption support that came in 4.0.1.
Also neeed to compile neo4j-java-driver in gms as well to include it in the WAR.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

feat: neo4j Bolt TLS support (#2100)
e9d4f16 
    Bumping version of neo4j-java-driver to include encryption support that came in 4.0.1.
    Also neeed to compile neo4j-java-driver in gms as well to include it in the WAR.
@RickardCardell RickardCardell marked this pull request as ready for review February 26, 2021 11:16
shirshanka
shirshanka approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 3252e92 into datahub-project:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RickardCardell @shirshanka @jjoyce0510