Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docker): add large generated directories to dockerignore #2151

Merged
merged 3 commits into from
Mar 2, 2021
Merged

build(docker): add large generated directories to dockerignore #2151

merged 3 commits into from
Mar 2, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 2, 2021

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

jplaisted
jplaisted approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@jplaisted jplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once checks pass, thanks!

@jplaisted
Copy link
Contributor

Python tests failed. I assume this is unrelated to this exact PR, but might be related to your other work?

E: Unable to locate package python-ldap

@shirshanka
Copy link
Contributor

Moving this forward to clear the backlog of PRs

@hsheth2 hsheth2 mentioned this pull request Mar 2, 2021
Merged
4 tasks
@shirshanka shirshanka merged commit 11532a1 into datahub-project:master Mar 2, 2021
@hsheth2 hsheth2 deleted the dockerignore branch November 10, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplaisted jplaisted jplaisted approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @jplaisted @shirshanka