Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): capture table descriptions #2157

Merged
merged 1 commit into from
Mar 2, 2021
Merged

feat(ingest): capture table descriptions #2157

merged 1 commit into from
Mar 2, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 2, 2021

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@hsheth2 hsheth2 force-pushed the table_descriptions branch from 93c58f5 to cd569c0 Compare March 2, 2021 19:09
shirshanka
shirshanka approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

metadata-ingestion/src/datahub/ingestion/source/sql_common.py
except NotImplementedError:
description = None

# TODO: capture inspector.get_pk_constraint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@shirshanka shirshanka merged commit 0310e97 into datahub-project:master Mar 2, 2021
@hsheth2 hsheth2 deleted the table_descriptions branch November 10, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka