Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GraphQL): Bubbling up exceptions logged in GraphQL resolvers #2163

Merged
merged 1 commit into from
Mar 3, 2021
Merged

fix(GraphQL): Bubbling up exceptions logged in GraphQL resolvers #2163

merged 1 commit into from
Mar 3, 2021

Conversation

jjoyce0510
Copy link
Collaborator

Including underlying exception in GQL resolver exceptions. Useful for debugging.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shirshanka
shirshanka approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit ae1c21a into datahub-project:master Mar 3, 2021
@joemirizio
Copy link
Contributor

Thanks again! This was a huge help in diagnosing my issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjoyce0510 @joemirizio @shirshanka