feat(DataPlatform Logos): Adding server driven logos #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
reviewed
Mar 4, 2021
| @@ -10,14 +7,5 @@ export function getLogoFromPlatform(platform: string) { | |||
| if (platform === 'Looker') { | |||
| return lookerLogo; | |||
There was a problem hiding this comment.
Dashboards and Charts do not have DataPlatformUrns. Thus there is no way we can push these from the server. My view is that we should migrate Charts + Dashboards to also use DataPlatformUrns and then do the same here. Until then, this will unfortunately have to remain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This change populates the recently added "logoUrl" field of DataPlatformInfo.json.
Description
Adding logo URLs for each DataPlatform. Images will be stored in the repo, similar to what we do for the existing images (default avatar, etc).
Checklist