Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): Add SHA based tagging before pushing to docker registries #2204

Merged
merged 2 commits into from
Mar 10, 2021
Merged

feat(ci): Add SHA based tagging before pushing to docker registries #2204

merged 2 commits into from
Mar 10, 2021

Conversation

dexter-mh-lee
Copy link
Contributor

Changes included in PR

  1. Add short SHA based tagging for pushes to master. Solves issue Make use of tagged releases #2162
  2. Upgrade to v2 of docker/build-and-push-action which simplifies our workflow
  3. Make sure the push actions do not run when docker password is not set

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka shirshanka changed the title feat(git-workflows): Add SHA based tagging before pushing to docker regiestries feat(ci): Add SHA based tagging before pushing to docker regiestries Mar 10, 2021
@shirshanka shirshanka changed the title feat(ci): Add SHA based tagging before pushing to docker regiestries feat(ci): Add SHA based tagging before pushing to docker registries Mar 10, 2021
shirshanka
shirshanka requested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to change the datahub-frontend-react compose to use the new image name (datahub-frontend-react)

@dexter-mh-lee
Copy link
Contributor Author

Fixed docker-compose.react.yml!

shirshanka
shirshanka approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
This looks great and I love that the builds will be faster now :)

@shirshanka shirshanka merged commit b02039c into datahub-project:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexter-mh-lee @shirshanka