feat(ingestion): add option for optimized skipping of schemas #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsheth2 This is not the prettiest change I know, but I wanted to just put the PR out there to make any discussion about issue #2208 more concrete. For context, I am stumbling on this when trying to ingest from aws athena where we have in our non-production environment a truly polluted metastore with a ridiculous number of garbage schemas, whereas the number of schemas I would be interested in ingesting from is on the order of <10. |
hsheth2
requested changes
Mar 10, 2021
| dataset_snapshot.aspects.append(dataset_properties) | ||
| schema_metadata = get_schema_metadata( | ||
| self.report, dataset_name, platform, columns | ||
| if sql_config.schema_pattern.allowed(schema): |
There was a problem hiding this comment.
Could we use something along these lines:
if not sql_config.schema_pattern.allowed(schema):
self.report.report_dropped(schema)
continueIt will help localize the reporting alongside the if statement and keep the indentation a bit less deep. I was planning on doing this for table_pattern as well.
There was a problem hiding this comment.
Agree and fixed.
hsheth2
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2208
Checklist