Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es-7-migration): Update script and migration docs and add a simple Dockerfile #2229

Merged

Conversation

dexter-mh-lee
Copy link
Contributor

The script requires ssl configuration even if we disable ssl. Update the script to take optional disable-ssl params for source and destination.

Add simple Dockerfile to run a docker container that runs the script.

Update migration doc with recommendations on how to migrate to es7.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@dexter-mh-lee
Copy link
Contributor Author

@shirshanka @jplaisted Please take a look! Let me know if the migration plan needs more details.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@jplaisted any modifications you would like to see?

Maybe branch name should be called elastic-5-legacy ?

@jplaisted
Copy link
Contributor

I'm fine with whatever name for the branch. Naming is hard, bikeshedding probably not worth it :p

@shirshanka did you want to cut a release before ES7? Maybe a 0.6.2 the immediately a 0.7.0? Up to you, I'm not sure if there are other breaking changes other than ES, if not then this would let people upgrade as far as possible without going to ES7.

@dexter-mh-lee
Copy link
Contributor Author

+1 to having two releases. If we decide on the version numbers, I can add that into the readme as well.

@jplaisted
Copy link
Contributor

I think if there's no other major breaking changes other than ES7 then 0.6.2 and 0.7 will work. Otherwise 0.7 and 0.8 (where 0.8 is ES7, ironically). If its too hard to tell we can just do 0.7 and 0.8.

@shirshanka shirshanka merged commit 2730592 into datahub-project:es-7-support Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants