Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kafka-servers): Fix the issue of gms/mae/mce not starting when multiple kafka servers are set #2231

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix(kafka-servers): Fix the issue of gms/mae/mce not starting when multiple kafka servers are set #2231

merged 1 commit into from
Mar 12, 2021

Conversation

dexter-mh-lee
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee commented Mar 12, 2021 •
edited
Loading

Fixes #2225
If we set KAFKA_BOOTSTRAP_SERVERS as a comma separated list of brokers, we need to wait for each one separately.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shirshanka
shirshanka approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
We should combine these configs at a future date.

@shirshanka shirshanka merged commit 8d731b5 into datahub-project:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS MSK - Error too many colons in address
2 participants
@dexter-mh-lee @shirshanka