Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(React): All entity search UI + misc improvements #2233

Merged
merged 3 commits into from
Mar 13, 2021
Merged

refactor(React): All entity search UI + misc improvements #2233

merged 3 commits into from
Mar 13, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Mar 12, 2021 •
edited
Loading

Scope
React App

Changes

  1. Add loading indicator to "all" entity search tab
  2. Add "no data" feedback if no results are found across all entities
  3. Replace hardcoded entity search in UserDetails with only entities enabled for search
  4. Add light gray "no description" to search result w empty descripton
  5. Fix "user is not a browsable entity" error from BrowsableEntityPage

Screen Shot 2021-03-12 at 2 16 10 PM

Screen Shot 2021-03-12 at 2 15 58 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shirshanka
shirshanka approved these changes Mar 13, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 595d367 into datahub-project:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @shirshanka