Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add looker metadata ingestion examples #2315

Conversation

grantatspothero
Copy link
Contributor

@grantatspothero grantatspothero commented Mar 30, 2021

Adds (very experimental) support for ingesting Looker metadata (views, charts, dashboards) into datahub through scraping LookML and scraping the Looker API.

SpotHero built this POC a few months ago before datahub officially supported ingesting dashboards into datahub. As a workaround, we created "virtual" datasets corresponding to Looker dashboards/charts so we could test out lineage between dashboards.

We are sharing these scripts since there is some interest around ingesting Looker metadata into datahub, but SpotHero does not have the time to robustly build this support out. If others are curious and want to try ingesting Looker metadata, this would be a good place to start!

@grantatspothero grantatspothero force-pushed the spothero-looker-ingestion-examples branch from 7eceaca to 09449d8 Compare March 30, 2021 20:09
@shirshanka
Copy link
Contributor

Thanks a ton for pushing this over the line, @grantatspothero!
Could you move these over to https://github.com/linkedin/datahub/tree/master/contrib/metadata-ingestion/python ?
We could accept it there easily, and then fix it up over time to make them official.

…tahub

Intended as examples for building out more robust support for Looker integrations and not a fully featured and reliable metadata ingestion
@grantatspothero grantatspothero force-pushed the spothero-looker-ingestion-examples branch from 96a0728 to 773cbfa Compare April 2, 2021 15:45
@grantatspothero
Copy link
Contributor Author

@shirshanka done, I also squashed all the commits on this branch and tried to follow the contrib guidelines for commit messages. Let me know if I missed a step!

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the contrib @grantatspothero

@shirshanka shirshanka merged commit fce8a53 into datahub-project:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants