Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): add support for database and table patterns to glue source #2339

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 5, 2021

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@shirshanka shirshanka merged commit c1f3eae into datahub-project:master Apr 6, 2021
@hsheth2 hsheth2 deleted the glue-improv branch April 6, 2021 00:14
@shirshanka
Copy link
Contributor

@amonkhouse @HarryNash : FYI this is a breaking change to the previously committed Glue support for one config parameter.
databases: is now replaced by : database_pattern: which conforms to the allow-deny pattern we are using for all other sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants