Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tags): Add tag graph builder #2341

Merged
merged 3 commits into from
Apr 6, 2021
Merged

feat(tags): Add tag graph builder #2341

merged 3 commits into from
Apr 6, 2021

Conversation

frsann
Copy link
Contributor

@frsann frsann commented Apr 6, 2021

We add a tag graph builder so that tags can be ingested properly.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

gabe-lyons
gabe-lyons reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good aside one question on the setRemovedProperty call

shirshanka
shirshanka approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit fb559cb into datahub-project:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frsann @shirshanka @gabe-lyons