fix(ingestion): properly detect optional fields in avro schemas #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Apr 6, 2021
| @@ -71,7 +71,7 @@ def avro_schema_to_mce_fields(avro_schema_string: str) -> List[SchemaField]: | |||
| type=_get_column_type(parsed_field.type), | |||
| description=parsed_field.props.get("doc", None), | |||
| recursive=False, | |||
| nullable=(parsed_field.type == "null"), | |||
| nullable=parsed_field.has_default, | |||
There was a problem hiding this comment.
Fields can also be null if they are of type [ "null", "something else" ] as discussed here. This change will miss those cases, right?
There was a problem hiding this comment.
For full correctness, the nullable logic might need to be a bit more complex: union types should inherit their default values and nullability from the first type in the union.
This might be ok to do in a follow-up PR
There was a problem hiding this comment.
Thanks, my avro knowledge is far from good. I updated the PR to a solution that more closely resembles the existing behaviour. Please let me know what you think.
jjoyce0510
reviewed
Apr 6, 2021
jjoyce0510
reviewed
Apr 7, 2021
metadata-ingestion/src/datahub/ingestion/extractor/schema_util.py
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Apr 7, 2021
jjoyce0510
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Looks great to me - Thanks Thomas!
@shirshanka Can we get this merged in?
shirshanka
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2342
Checklist