Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datajob and dataflow search #2418

Merged
merged 7 commits into from
Apr 21, 2021

Conversation

frsann
Copy link
Contributor

@frsann frsann commented Apr 19, 2021

Searching for datajobs and dataflows was not implemented correctly, so this PR should fix it. The mappings.json might be suboptimal, so please take a close look at them.

@frsann frsann marked this pull request as ready for review April 21, 2021 05:47
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good- thanks @frsann 👍

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit e88a671 into datahub-project:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants