Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add dataJob, dataFlow entities and preview, profile pages and graphql mock & refactor with fragments #2419

Merged
merged 10 commits into from
Apr 21, 2021
Merged

feat(react): add dataJob, dataFlow entities and preview, profile pages and graphql mock & refactor with fragments #2419

merged 10 commits into from
Apr 21, 2021

Conversation

topwebtek7
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

gabe-lyons
gabe-lyons approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

shirshanka
shirshanka approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Much cleaner with fragments :)

jjoyce0510
jjoyce0510 reviewed Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

topwebtek7 added 10 commits April 21, 2021 09:12
@topwebtek7 topwebtek7 force-pushed the FeatReactAddDataJobDataFlowAndMock branch from ea4aafe to 78221ce Compare April 21, 2021 16:17
shirshanka
shirshanka approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @topwebtek7

@shirshanka shirshanka merged commit 1c07183 into datahub-project:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@gabe-lyons gabe-lyons gabe-lyons approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topwebtek7 @shirshanka @gabe-lyons @jjoyce0510