feat(ingestion): adding superset ingestion source #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tSupersetIngestion
…tSupersetIngestion
…tSupersetIngestion
…tSupersetIngestion
jjoyce0510
reviewed
Apr 21, 2021
| @@ -7,5 +8,8 @@ export function getLogoFromPlatform(platform: string) { | |||
| if (platform.toLowerCase() === 'looker') { | |||
| return lookerLogo; | |||
| } | |||
| if (platform.toLowerCase() === 'superset') { | |||
There was a problem hiding this comment.
We've got to push this from backend. Forgot about this.
hsheth2
approved these changes
Apr 21, 2021
| test_response = self.session.get(f"{self.config.connect_uri}/api/v1/database") | ||
| if test_response.status_code == 200: | ||
| pass | ||
| # TODO(Gabe): how should we message about this error? |
There was a problem hiding this comment.
maybe just do test_response.raise_for_status() and let the caller deal with the error?
There was a problem hiding this comment.
Sg- I can handle that in a follow up.
| f"urn:li:dataset:(" | ||
| f"{platform_urn},{database_name + '.' if database_name else ''}" | ||
| f"{schema_name + '.' if schema_name else ''}" | ||
| f"{table_name},{self.env})" |
There was a problem hiding this comment.
definitely not necessary for this PR, but we have mce_builders.py which lets you do builder.make_dataset_urn(platform, name, env) - my eventual goal is to put all the URN construction stuff there
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingests via Superset's REST API. Currently populates chart/dashboard information. Followup work
Checklist